Update API for requesting dataflow plan optimization #1278
Merged
+100
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2024
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 14, 2024
This was referenced Jun 14, 2024
tlento
force-pushed
the
consolidate-where-filter-merging
branch
from
02bc582 to
451ab0d
Compare
tlento
force-pushed
the
update-dataflow-optimizer-call-mechanism
branch
from
5a904ed to
ae3d6ff
Compare
This was referenced Jun 25, 2024
tlento
force-pushed
the
consolidate-where-filter-merging
branch
from
451ab0d to
ad0298d
Compare
In order to fully support predicate pushdown via the DataflowPlanOptimizer framework we need two things: 1. Support for optimization in distinct values queries 2. The ability to share components between the DataflowPlanBuilder and the PredicatePushdownOptimizer This update addresses both of these concerns by doing a small restructure of the DataflowPlanBuilder interface for accepting optimizers. Instead of accepting a sequence of optimizer instances, the build_plan method will now accept a sequence of optimization enumerations. Those will then be converted to instances via the factory class added in this change. From there the update to the distinct values plan method signature was a trivial addition. Note - snapshot updates should be limited to ID numbers due to the added call to the DataflowPlanNodeOutputDataSetResolver in the distinct values plan.
tlento
force-pushed
the
update-dataflow-optimizer-call-mechanism
branch
from
ae3d6ff to
8d4d7fd
Compare
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fully support predicate pushdown via the DataflowPlanOptimizer
framework we need two things:
and the PredicatePushdownOptimizer
This update addresses both of these concerns by doing a small restructure
of the DataflowPlanBuilder interface for accepting optimizers. Instead of
accepting a sequence of optimizer instances, the build_plan method will now
accept a sequence of optimization enumerations. Those will then be converted
to instances via the factory class added in this change.
From there the update to the distinct values plan method signature was
a trivial addition.
Note - snapshot updates should be limited to ID numbers due to the added
call to the DataflowPlanNodeOutputDataSetResolver in the distinct values
plan.